This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Update tarpaulin attributes #2200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
So in 0.13.4 (yanked) tarpaulin actually started passing --cfg=tarpaulin so users could do #[cfg_attr(tarpaulin, ignore)] to ignore certain tests in coverage and also conditionally include/exclude code in coverage. This had the unintended result of breaking the recommended skip attr.
Because of that 0.13.4 was yanked and later on a 0.14.0 version released which still did --cfg=tarpaulin but also --cfg=tarpaulin_include so that code could now be skipped but still included if you did #[cfg(not(tarpaulin_include))]. There's also an unstable #[tarpaulin::skip] tool attribute for those using nightly.
This PR changes time to use the new attributes as a user of time and tarpaulin found this broke their coverage CI.
Link to relevant tarpaulin issue: xd009642/tarpaulin#487
testing/benchmarking notes
I struggled to get holochain building and running coverage on it. Still working on that but it shouldn't functionally impact any code just driving the tarpaulin source analysis and exclusion functionality.