package holochain package & tests via crane; refactor nix version management #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavHau
force-pushed
the
develop-dave
branch
2 times, most recently
from
5abefb7
to
abb142b
Compare
|
hey @DavHau, (i'm the author of #1764) not sure how helpful this will be, but i just tried running I'm running the latest macOS, let me know if i can provide any more information, retry another way, or be helpful in another way. thanks for your work on this! edit: interesting, this is probably a nix bug, since after reading through the comments in nixos/nix#3605, i tried edit 2: |
- ./nix/compat.nix (flake-compat) is used for downward compatibility - `nix-shell` still uses the old definitions, not the ones from the flake. - niv isn't used anymore but still kept as CI does niv add holochain-nixpkgs - copied some sh scripts from holonix - crane is used for .#holochain - tests are under .#holochain-tests
|
@DrewMcArthur Thanks a lot for testing. The problem should be fixed by holochain/holochain-nixpkgs#996 |
|
@DavHau definitely! i've been following holochain for a long time, so excited to be able to contribute. i've sorta left comments all over the place today, but here's an attempt at a summary:
that said, thanks for the update. i checked out this branch, and here's my results:
that says to me, the |
DavHau
force-pushed
the
develop-dave
branch
3 times, most recently
from
937bebf
to
f79dd3b
Compare
|
@DrewMcArthur Thanks again for your intense testing and your fixes. Could you give it a try again and let me know? |
|
@DavHau left this comment on #1776 - that branch works for me! |
2 tasks
|
almost all of this, or a version thereof, has been merged in #1863 thanks for the great work @DavHau and thank you for testing @DrewMcArthur 🙏 |
|
awesome @steveej! and do i understand correctly that holochain.love is a reflection of the current main branch? i.e. i can test on my macbook with that url now? or is there a release cycle i need to wait for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the nix code to use nix flakes for version management. (downward compat to old nix clients is established)
This prepares us for potential future steps:
holochainholochain-nixpkgsholonixinto onenix run .#...Things Done:
crate2nix(for experimenting only)nix-shellstill uses the old definitions, not the ones from the flake (keeping it compatible to the current CI).TODO: