Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AGP, Gradle and Kotlin Versions #1563

Merged
merged 1 commit into from Jun 8, 2021

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented May 24, 2021

Summary

This bumps AGP, Gradle, Kotlin, Ktlint.
The changes to file formatting are caused by an upgrade the the ktlint-gradle-plugin.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@runningcode runningcode force-pushed the no/bump-agp-gradle branch 4 times, most recently from deb7f53 to de168c4 Compare May 24, 2021 05:02
@dshokouhi
Copy link
Member

hmm a lil surprised that ktlint didn't pick up on the imports no longer being in the correct order, did they finally fix that? I know Android Studio always liked to add java* after kotlin* so I always had to manually correct it to keep ktlint happy lol

@runningcode
Copy link
Contributor Author

@dshokouhi, perhaps this change is related? pinterest/ktlint#701
what would you like me to do here? Should I revert the ktlint changes and make a separate PR for that?

@dshokouhi
Copy link
Member

@runningcode as long as ktlint doesn't complain I don't see any issues with it personally. My comment was merely an observation based on how often I have to correct the file to satisfy ktlint because anytime android studio imports a java item it places it at the bottom instead of alphabetically.

@runningcode
Copy link
Contributor Author

Oh, I think I misunderstood. Thanks for clarifying. All the code formatting in this PR was done with ktlint. I did not do any code formatting from Android Studio.

@JBassett JBassett merged commit 89457c5 into home-assistant:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants