Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastalne i18n ru #4366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fastalne i18n ru #4366

wants to merge 1 commit into from

Conversation

yurtpage
Copy link

I tried to find if it's possible to translate the app metadata on ht e
https://app.lokalise.com/
But it looks like it doesn't support it.

So here I added manually.

The Weblate allows to do the App Metadata translation.
Here is a sample of Conversations app metadata translation via Weblate https://translate.codeberg.org/projects/conversations/app-store-metadata-conversations/

Here is some description how to do that:
WeblateOrg/weblate#1525 (comment)

Anyway, please merge the PR

Signed-off-by: Yurt Page <yurtpage@gmail.com>
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yurtpage

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft April 26, 2024 22:01
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dshokouhi
Copy link
Member

if this is to be translated then we should probably also add this to lokalise if possible

@yurtpage yurtpage marked this pull request as ready for review April 28, 2024 19:37
@yurtpage
Copy link
Author

@dshokouhi sorry for pushing, I just didn't figured out that I should move the PR from draft state. So now it can be merged. As far I understood the F-Droid will automatically pull the translation.

@dshokouhi
Copy link
Member

So now it can be merged.

we dont know if we are going to keep translations in this repo or not so we will not be merging yet

@yurtpage
Copy link
Author

yurtpage commented May 8, 2024

Thank you

we dont know if we are going to keep translations in this repo

The F-Droid auto detects the fastlane folder by the
specific path https://f-droid.org/docs/All_About_Descriptions_Graphics_and_Screenshots/

Maybe this can be changed somehow, but given that meta description is not updated that often as in-app translation it shouldn't be a big burden to have them in the fastlane.

It looks like the localise.com supports the fastlane translations
https://lokalise.com/blog/automating-itunes-connect-deployment-with-fastlane-and-lokalise/

@dshokouhi
Copy link
Member

Maybe this can be changed somehow, but given that meta description is not updated that often as in-app translation it shouldn't be a big burden to have them in the fastlane.

Lokalise actually helps by allowing others to do easier language reviews and we dont have to clutter the PR area with translation PRs. It makes things easier to move forward.

You will need to have some patience while we figure out a way forward here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants