Use device class for binary sensor friendly state to match frontend and core #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
May 13, 2024
common/src/main/java/io/homeassistant/companion/android/common/data/integration/Entity.kt
Outdated
Show resolved
Hide resolved
…/data/integration/Entity.kt Co-authored-by: Joris Pelgröm <jpelgrom@users.noreply.github.com>
jpelgrom
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the device class for the friendly state translation when the domain is a binary sensor as those have unique states for on/off behavior.
Also updated our link to the proper HA frontend translation
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
ref: https://discord.com/channels/330944238910963714/562408603345092636/1237526500715266048