Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awattar icons and logos - https://www.awattar.at #5269

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mexx42
Copy link

@mexx42 mexx42 commented Mar 6, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look at the awatter website, they have an icon without text and a logo with the text to the right next to it and not below it.

./Klaas

@home-assistant home-assistant bot marked this pull request as draft March 6, 2024 16:51
@home-assistant
Copy link

home-assistant bot commented Mar 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klaasnicolaas klaasnicolaas added the has-parent This PR has a parent PR in a other repo label Mar 6, 2024
@mexx42
Copy link
Author

mexx42 commented Mar 6, 2024

i took the images from here (section logos) https://www.awattar.at/company/press

so basically there are no icons ... i thought of just using the rings as icon, but i am not sure if this is ok for them as its not in their ci ... ?

@mexx42 mexx42 changed the title added awattar - https://www.awattar.at Add awattar - https://www.awattar.at Mar 6, 2024
@mexx42 mexx42 changed the title Add awattar - https://www.awattar.at Add awattar icons and logos - https://www.awattar.at Mar 6, 2024
@klaasnicolaas
Copy link
Member

On Twitter they also only use the rings as a profile image and an icon with only the rings will also look better visually later in the integration list.

./Klaas

@mexx42 mexx42 marked this pull request as ready for review March 6, 2024 17:57
@klaasnicolaas
Copy link
Member

In terms of logo, I would prefer the wide variant with text on the right side.

./Klaas

@mexx42
Copy link
Author

mexx42 commented Mar 6, 2024

Yes, /me too, but then you don't have the "energy in sync with nature" text below, but i can change it if you want.

@klaasnicolaas
Copy link
Member

image

@mexx42
Copy link
Author

mexx42 commented Mar 6, 2024

Ok, sorry, i must have been blind ... one second, i will replace it

Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged 👍

@mexx42
Copy link
Author

mexx42 commented Mar 6, 2024

Thanks!

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants