Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinkPlay as core integration #5315

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dukeofphilberg
Copy link

@dukeofphilberg dukeofphilberg commented Mar 22, 2024

Proposed change

This PR moves the LinkPlay brand under the core integrations as it now has a core integration too.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@dukeofphilberg dukeofphilberg marked this pull request as ready for review March 22, 2024 10:39
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Mar 22, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds/handles two integrations?

Thanks should not be possible. Each integration needs to be in its own PR (this also applies to any other PR in our organization).

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 22, 2024 11:13
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dukeofphilberg dukeofphilberg changed the title Add ArtSound brand Add LinkPlay as core integration Mar 22, 2024
@dukeofphilberg
Copy link
Author

This PR adds/handles two integrations?

Thanks should not be possible. Each integration needs to be in its own PR (this also applies to any other PR in our organization).

../Frenck

Thanks, this has been addressed in all relevant PR's (core, docs, brands.)

@dukeofphilberg dukeofphilberg marked this pull request as ready for review March 22, 2024 13:34
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants