Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hailo images #5361

Merged
merged 4 commits into from
May 18, 2024
Merged

Added Hailo images #5361

merged 4 commits into from
May 18, 2024

Conversation

voldemarpanso
Copy link
Contributor

@voldemarpanso voldemarpanso commented Apr 10, 2024

Proposed change

Images for Hailo Libero custom integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @voldemarpanso 👋

I found a couple of small things that need to be addressed.

  1. The logo and icon are the same. The logo version is (IMHO) a worse version as it lacks transparency. I would suggest to remove the logo version from this PR (we will fallback automatically to the icon in that case).

  2. There is a mismatch in the domain and custom integration foldername as it seems.

CleanShot 2024-04-22 at 11 28 03

Could you take a look? 🙏

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 22, 2024 09:30
@voldemarpanso
Copy link
Contributor Author

Tbh I just looked around on their website. Logo was based on first one I saw there suitable for logo. Created icon later based on favicon, while I was just wondering if there's anything else suitable. Wasn't aware of fallback. I liked transparent one more as well.

@frenck frenck marked this pull request as ready for review May 18, 2024 12:07
@home-assistant home-assistant bot requested a review from frenck May 18, 2024 12:07
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @voldemarpanso 👍

../Frenck

@frenck frenck merged commit eb3ff91 into home-assistant:master May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants