-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon for custom integration SWS12500 Weather station. #5381
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @schizza 👋
We collect brands in this repository, I would have expected the branding of Sencor to be used here.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
* Add brand logo * both hDPI and normal * variant for dark background as original logo is black * Icon * both hDPI an normal variant
Ok, I see. I thought as this is custom component, that logo is for this custom component - I was wrong :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logos look like the icons in terms of size? The icons don't seem to match what the manufacturer is using for their branding?
../Frenck
Proposed change
Add icon for custom component SWS12500 weather station.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)