Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for custom integration SWS12500 Weather station. #5381

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

schizza
Copy link

@schizza schizza commented Apr 19, 2024

Proposed change

Add icon for custom component SWS12500 weather station.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @schizza 👋

We collect brands in this repository, I would have expected the branding of Sencor to be used here.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft April 22, 2024 08:33
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

* Add brand logo

   * both hDPI and normal
   * variant for dark background as original logo is black

* Icon

   *  both hDPI an normal variant
@schizza
Copy link
Author

schizza commented Apr 30, 2024

Hi there @schizza 👋

We collect brands in this repository, I would have expected the branding of Sencor to be used here.

../Frenck

Ok, I see. I thought as this is custom component, that logo is for this custom component - I was wrong :)
I have changed logo to Sencor brand and icon to integration icon? Is that right?

@schizza schizza marked this pull request as ready for review April 30, 2024 08:18
@home-assistant home-assistant bot requested a review from frenck April 30, 2024 08:18
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos look like the icons in terms of size? The icons don't seem to match what the manufacturer is using for their branding?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 24, 2024 14:00
@schizza
Copy link
Author

schizza commented May 24, 2024

The logos look like the icons in terms of size? The icons don't seem to match what the manufacturer is using for their branding?

../Frenck

The logo I have added is well know for years.

CleanShot 2024-05-24 at 16 18 05@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants