Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etf_monitor Branding #5422

Closed
wants to merge 3 commits into from

Conversation

Jef-NL
Copy link

@Jef-NL Jef-NL commented May 3, 2024

Proposed change

This PR adds the etf_monitor domain branding to the Brands list for publication of the custom integration in the HACS default integrations list.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/Jef-NL/ETF_Monitor

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branding provided in this PR doesn't seem to match the branding of the provide upstream which this integration integrates with.

CleanShot 2024-05-13 at 14 06 06@2x

Please adjust the PR to match the integrated service.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 12:06
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Jef-NL
Copy link
Author

Jef-NL commented May 21, 2024

The branding provided in this PR doesn't seem to match the branding of the provide upstream which this integration integrates with.

CleanShot 2024-05-13 at 14 06 06@2x

Please adjust the PR to match the integrated service.

../Frenck

Hi Frenck,

The branding added is just for the integration. Please note that this integration is not affiliated with JustETF GmbH. It only utilizes the public API provided by JustETF. Using their branding or logo would falsely suggest an official partnership and could violate copyright and trademark laws.

To avoid any such implications, the integration will not carry the JustETF logo. The API usage is credited within the integration and noted in the disclaimer. Additionally, written approval for the use of their API in this integration is still in progress but is not restricted by their legal terms and notice.

@Jef-NL Jef-NL marked this pull request as ready for review May 21, 2024 20:09
@home-assistant home-assistant bot requested a review from frenck May 21, 2024 20:09
@frenck
Copy link
Member

frenck commented May 21, 2024

It only utilizes the public API provided by JustETF

That is exactly what integrations do and what this repository is meant for. Integrations integrate with a device or service, in this case JustETF, thus we should add that as a branding for identification purposes.

If you don't want to add that branding, then we can alternatively close this PR, as integrations don't require to have branding to function.

../Frenck

@Jef-NL
Copy link
Author

Jef-NL commented May 21, 2024

Aah okey, Thanks for the clear feedback.

I can't say anything yet relating copyright and branding of external integratings so I'll close it for now.

@Jef-NL Jef-NL closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants