-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add etf_monitor Branding #5422
Add etf_monitor Branding #5422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi Frenck, The branding added is just for the integration. Please note that this integration is not affiliated with JustETF GmbH. It only utilizes the public API provided by JustETF. Using their branding or logo would falsely suggest an official partnership and could violate copyright and trademark laws. To avoid any such implications, the integration will not carry the JustETF logo. The API usage is credited within the integration and noted in the disclaimer. Additionally, written approval for the use of their API in this integration is still in progress but is not restricted by their legal terms and notice. |
That is exactly what integrations do and what this repository is meant for. Integrations integrate with a device or service, in this case JustETF, thus we should add that as a branding for identification purposes. If you don't want to add that branding, then we can alternatively close this PR, as integrations don't require to have branding to function. ../Frenck |
Aah okey, Thanks for the clear feedback. I can't say anything yet relating copyright and branding of external integratings so I'll close it for now. |
Proposed change
This PR adds the
etf_monitor
domain branding to the Brands list for publication of the custom integration in the HACS default integrations list.Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)