-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon and logo for Aidot #5438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @s1eedz 👍
@s1eedz Was there a reason for the merge? Was there a conflict? Did something change? Not fully understanding the action here and the reasoning behind it. ../Frenck |
@frenck This is a new integration for aidot. Main code link: home-assistant/core#117337. I don't see a conflict, is there something wrong? If so, thank you very much for your correction. I'll quickly revise my question here. |
I know you did, the logs tells us. I didn't understand why and was asking about that. Was there something wrong? Why was it needed to merge the branch? |
I see that the branch is out-of-date,and then there's an update button, so I. . . .. . . .Maybe I can discard these merge commits through git operations, and I'll learn how to do that. . .this may take a while... |
The PR was approved, you made changes by updating the branch. This causes the CI to require a new approval and uses CI resources to test/validate your PR again. Normally, there is no need for this, unless there is a conflict or change (or weeks have passed). Considering that, I assumed something has changed... if not, then please don't do that. Thanks 👍 ../Frenck |
Thank you for telling this, I'm sorry for this. |
@s1eedz, what are you trying to do? Why did you close this PR now? |
Proposed change
Add icon and logo for Aidot
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)