Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limych/car wash #5447

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Limych/car wash #5447

wants to merge 4 commits into from

Conversation

Limych
Copy link
Contributor

@Limych Limych commented May 9, 2024

Proposed change

This is a reopening of PR #2775

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
    https://github.com/Limych/ha-car_wash

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... but the review comment from linked PR wasn't resolved.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 11:59
@Limych
Copy link
Contributor Author

Limych commented May 17, 2024

@frenck, I don't understand what comment you are talking about. Could you please repeat it here?

@frenck
Copy link
Member

frenck commented May 17, 2024

#2775 (comment)

@Limych
Copy link
Contributor Author

Limych commented May 17, 2024

I'm sorry, I don't understand again — change what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants