Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icon and Logo for Custom Integration - SAAS - Sleep As Android Status #5448

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sudoxnym
Copy link

@sudoxnym sudoxnym commented May 10, 2024

Adding the icon for my custom integration that allows for different status's to be tracked via Sleep As Android App.

Proposed change

adding icon for custom repo saas

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • [x ] Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • [x ] The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @sudoxnym 👋

The PR template isn't filled out, and is thus missing links to where I can find this custom integration.

Can you please properly fill out the template, provide a description and a proper PR title that is descriptive?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 11:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@sudoxnym
Copy link
Author

My apologies. Somehow didn't see the middle, filled out everything that applies hitting button next

@sudoxnym sudoxnym marked this pull request as ready for review May 13, 2024 16:48
@home-assistant home-assistant bot requested a review from frenck May 13, 2024 16:48
@sudoxnym sudoxnym changed the title Add files via upload Add Icon and Logo for Custom Integration - SAAS - Sleep As Android Status May 13, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a reference for this app or the manufacturer of this app (and thus validation their branding against this PR).

Could you point me to it?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 18:50
@sudoxnym
Copy link
Author

My apologies, I'm super new to the world of developing. If you're referring to the app as saas, then I made saas, ground up, if you're referring to the original app, that is Sleep As Android, they have different branding. My integration doesn't connect directly to their app, it just listens for the MQTT topic it puts out. I'm willing to add anything necessary though if pointed in the right direction.

@sudoxnym sudoxnym marked this pull request as ready for review May 13, 2024 18:57
@home-assistant home-assistant bot requested a review from frenck May 13, 2024 18:57
@frenck
Copy link
Member

frenck commented May 13, 2024

My apologies, I'm super new to the world of developing.

No worries, I'll try to explain.

We collect the branding of manufacturers of devices or providers of services that an integration connects/integrates into this repository (regardless of transport).

I'm trying to figure out which service this integration integrates with and the branding that goes with it so I can validate that the provided branding in this PR matches the upstream branding.

../Frenck

@frenck frenck marked this pull request as draft May 13, 2024 19:02
@sudoxnym
Copy link
Author

I'm slightly embarrassed for not knowing this stuff, you're one of my heroes lol. I'm hoping this is what you were asking for.
https://sleep.urbandroid.org/

@frenck
Copy link
Member

frenck commented May 13, 2024

Right, which brings me to the points of:

CleanShot 2024-05-13 at 21 15 41@2x

Doesn't match with what has been provided in this PR.

../Frenck

@sudoxnym
Copy link
Author

So I'd have to use their logo? Does that mean I'd need to get in contact with them and permission? The logo provided was made by me and designed for saas specifically. Sorry for confusion.

@sudoxnym
Copy link
Author

Sorry for the lack of knowledge, but if you could direct me in my next steps I'd be happy to follow them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants