-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icon and Logo for Custom Integration - SAAS - Sleep As Android Status #5448
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @sudoxnym 👋
The PR template isn't filled out, and is thus missing links to where I can find this custom integration.
Can you please properly fill out the template, provide a description and a proper PR title that is descriptive?
Thanks 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
My apologies. Somehow didn't see the middle, filled out everything that applies hitting button next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find a reference for this app or the manufacturer of this app (and thus validation their branding against this PR).
Could you point me to it?
../Frenck
My apologies, I'm super new to the world of developing. If you're referring to the app as saas, then I made saas, ground up, if you're referring to the original app, that is Sleep As Android, they have different branding. My integration doesn't connect directly to their app, it just listens for the MQTT topic it puts out. I'm willing to add anything necessary though if pointed in the right direction. |
No worries, I'll try to explain. We collect the branding of manufacturers of devices or providers of services that an integration connects/integrates into this repository (regardless of transport). I'm trying to figure out which service this integration integrates with and the branding that goes with it so I can validate that the provided branding in this PR matches the upstream branding. ../Frenck |
I'm slightly embarrassed for not knowing this stuff, you're one of my heroes lol. I'm hoping this is what you were asking for. |
So I'd have to use their logo? Does that mean I'd need to get in contact with them and permission? The logo provided was made by me and designed for saas specifically. Sorry for confusion. |
Sorry for the lack of knowledge, but if you could direct me in my next steps I'd be happy to follow them. |
Adding the icon for my custom integration that allows for different status's to be tracked via Sleep As Android App.
Proposed change
adding icon for custom repo saas
Type of change
Python wheels repository
Additional information
https://www.github.com/sudoxnym/saas
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)