-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Viam image processing integration #101786
Add Viam image processing integration #101786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
272e82f
to
0056dfc
Compare
0c7d4d6
to
94e0e51
Compare
ada700f
to
b7e0a37
Compare
b7e0a37
to
fddca1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the docs PR to the description, which is required for a new integration
fddca1b
to
0ae69fb
Compare
Thanks for the feedback @edenhaus! Updated the description with that link. |
e03a410
to
9544aec
Compare
c8c6bd3
to
0b84e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @HipsterBrown 👍
This reverts commit 55bf0b6.
Proposed change
Add Viam as an official integration with Home Assistant. This integration will allow Home Assistant users to push data from their Home Assistant-controlled spaces to Viam and use the provided services to make those spaces smarter! For example, capture camera images and use them to create custom machine learning models; when paired with the Viam SDK, those models can allow for intelligent automation within Home Assistant. Models can be used on devices running viam-server through the
get_detections
andget_classifications
services added by this integration.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: