Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Viam image processing integration #101786

Merged
merged 27 commits into from
May 14, 2024

Conversation

HipsterBrown
Copy link
Contributor

@HipsterBrown HipsterBrown commented Oct 10, 2023

Proposed change

Add Viam as an official integration with Home Assistant. This integration will allow Home Assistant users to push data from their Home Assistant-controlled spaces to Viam and use the provided services to make those spaces smarter! For example, capture camera images and use them to create custom machine learning models; when paired with the Viam SDK, those models can allow for intelligent automation within Home Assistant. Models can be used on devices running viam-server through the get_detections and get_classifications services added by this integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HipsterBrown

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the docs PR to the description, which is required for a new integration

@home-assistant home-assistant bot marked this pull request as draft October 31, 2023 13:19
@HipsterBrown HipsterBrown marked this pull request as ready for review October 31, 2023 14:05
@HipsterBrown
Copy link
Contributor Author

Thanks for the feedback @edenhaus! Updated the description with that link.

@HipsterBrown HipsterBrown force-pushed the viam-integration branch 2 times, most recently from e03a410 to 9544aec Compare November 1, 2023 19:08
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @HipsterBrown 👍

@emontnemery emontnemery merged commit 55bf0b6 into home-assistant:dev May 14, 2024
38 checks passed
emontnemery added a commit that referenced this pull request May 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants