Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ical to 6.1.0 #103759

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Bump ical to 6.1.0 #103759

merged 2 commits into from
Nov 11, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Nov 10, 2023

Proposed change

Release notes: https://github.com/allenporter/ical/releases/tag/6.1.0
Changs: allenporter/ical@6.0.0...6.1.0

Motivation is to see if this addresses timeout issues in #103483 by dropping dependency on emoji library which loads a 2MB .py file. The other changes includes adding support for parent/child relationships which are not yet used by Home Assistant, but can be used if/when we want to improve To-do with parent/child.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@allenporter
Copy link
Contributor Author

allenporter commented Nov 10, 2023

CI checks break because ical no longer depends on emoji, and this breaks mypy for another library:

Error: venv/lib/python3.11/site-packages/slixmpp/plugins/xep_0444/stanza.py:9: error: Cannot find implementation or library stub for module named "emoji"  [import-not-found]
venv/lib/python3.11/site-packages/slixmpp/plugins/xep_0444/stanza.py:9: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 6268 source files)
Error: Process completed with exit code 1.

It looks like slixmpp does not directly depend on emoji, but tries to import it and if it can't be imported it catches the ImportError with a fallback
https://github.com/poezio/slixmpp/blob/7a0fb970833c778ed50dcb49c5b7b4043d57b1e5/slixmpp/plugins/xep_0444/stanza.py#L9

After reading the mypy guidance, I'm not sure what the right fix is. I don't think the answer is for ical to keep an unnecessary dependency on emoji. I'm not sure that what slixmpp is doing is wrong. Not sure what mypi is doing is necessarily wrong either or if its a good idea to suppress or how.

Would appreciate feedback on how to proceed.

@frenck
Copy link
Member

frenck commented Nov 10, 2023

@allenporter I would add emoji library to the manifest the other integration to fix this for now.

@allenporter allenporter requested a review from fabaff as a code owner November 11, 2023 01:58
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @allenporter 👍

../Frenck

@frenck frenck merged commit 048b989 into home-assistant:dev Nov 11, 2023
dgomes pushed a commit to dgomes/home-assistant that referenced this pull request Nov 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
@frenck frenck added this to the 2023.11.3 milestone Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants