Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiocomelit to 0.5.2 #103791

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Nov 11, 2023

Proposed change

Bump aiocomelit to 0.5.2:

changelog: https://github.com/chemelli74/aiocomelit/releases/tag/v0.5.2
diff: chemelli74/aiocomelit@v0.3.0...v0.5.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@chemelli74 chemelli74 changed the title Bump aoicomelit to 0.5.0 Bump aiocomelit to 0.5.0 Nov 11, 2023
@chemelli74 chemelli74 added this to the 2023.11.3 milestone Nov 11, 2023
bdraco
bdraco previously approved these changes Nov 12, 2023
@bdraco
Copy link
Member

bdraco commented Nov 12, 2023

I'm thinking the cache load does blocking I/O so it should probably be run in the executor with loop.run_in_executor(None, functools.partial(pint.UnitRegistry, cache_folder=":auto:"))
chemelli74/aiocomelit@v0.3.0...v0.5.0#diff-1f078fe6ed0aa735bd88fc5e836cd3d1a9f355dd2a282a433892409c8b2d94bfR234

@bdraco bdraco dismissed their stale review November 12, 2023 02:38

Missed that this does I/O on the first pass

@chemelli74 chemelli74 changed the title Bump aiocomelit to 0.5.0 Bump aiocomelit to 0.5.2 Nov 13, 2023
@chemelli74 chemelli74 merged commit 7ab4d97 into home-assistant:dev Nov 13, 2023
@chemelli74 chemelli74 deleted the chemelli74-aiocomelit-bump branch November 13, 2023 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comelit Integration Lags status update
3 participants