Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Google Calendar API returning invalid RRULE:DATE rules #103870

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Nov 12, 2023

Proposed change

Fix and test for Google Calendar API returning invalid rules that don't match the rfc5545 expectations. There are a couple problems going on here:

  • First, the client library gcal_sync coerces the RRULE;DATE to be RDATE ("DATE" in an RRULE is not a thing). The initial fix didn't work and the fix in 6.0.1 actually works this time fixed in Bump gcal_sync to 6.0.1 #103861.
  • Second, google integration has a bug where lstrip of RRULE was used where removeprefix was more appropriate. The result is that RDATE was converted to DATE since R is in RRULE. This check has been modified.
  • Third, google now only passes up RRULE rules (ignoring RDATE or EXDATE rules which are not supported by the Home Assistant frontend). These continue to be treated as flattened event instances, rather than as part of a series.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@balloob balloob merged commit abb1328 into home-assistant:dev Nov 12, 2023
@balloob
Copy link
Member

balloob commented Nov 12, 2023

Thanks!

Should this go to a milestone?

@allenporter allenporter added this to the 2023.11.3 milestone Nov 12, 2023
@allenporter
Copy link
Contributor Author

Thanks!

Should this go to a milestone?

Done. Also tagged #103861 which is a pre-req.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching Google Calendar data: Invalid recurrence rule in 2023.04.2
3 participants