Fix for Google Calendar API returning invalid RRULE:DATE rules #103870
+55
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix and test for Google Calendar API returning invalid rules that don't match the rfc5545 expectations. There are a couple problems going on here:
gcal_sync
coerces theRRULE;DATE
to beRDATE
("DATE" in an RRULE is not a thing). The initial fix didn't work and the fix in6.0.1
actually works this time fixed in Bump gcal_sync to 6.0.1 #103861.lstrip
ofRRULE
was used whereremoveprefix
was more appropriate. The result is thatRDATE
was converted toDATE
sinceR
is inRRULE
. This check has been modified.RRULE
rules (ignoringRDATE
orEXDATE
rules which are not supported by the Home Assistant frontend). These continue to be treated as flattened event instances, rather than as part of a series.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: