Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smarttub to 0.0.36 #103948

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Update smarttub to 0.0.36 #103948

merged 3 commits into from
Nov 14, 2023

Conversation

mdz
Copy link
Contributor

@mdz mdz commented Nov 14, 2023

Proposed change

Update smarttub to 0.0.36

mdz/python-smarttub@v0.0.35...v0.0.36

To get the tiny fix for mdz/python-smarttub#40

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
@MartinHjelmare MartinHjelmare changed the title update smarttub to 0.0.36 Update smarttub to 0.0.36 Nov 14, 2023
@MartinHjelmare
Copy link
Member

0.0.36 isn't on PyPI yet.

@MartinHjelmare MartinHjelmare marked this pull request as draft November 14, 2023 06:28
@mdz
Copy link
Contributor Author

mdz commented Nov 14, 2023

CI pipeline failed due to PEBKAC error. Fixed now

@mdz mdz marked this pull request as ready for review November 14, 2023 07:14
@edenhaus
Copy link
Contributor

CI / Run tests Python 3.11 (9) (pull_request) is unrelated

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdz 👍

@edenhaus edenhaus added this to the 2023.11.3 milestone Nov 14, 2023
@edenhaus edenhaus merged commit 0a84c2d into home-assistant:dev Nov 14, 2023
@mdz mdz deleted the smarttub-0.0.36 branch November 15, 2023 03:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants