Fix ESPHome BLE client raising confusing error when not connected #104146
+107
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The
@verify_connected
decorator should have checkedself._is_connected
before trying to make the request to the aioesphomeapi lib so it could raise a helpful error instead of hitting an error inside the lib about the connection not being establishedIt was discovered in #102188 that some libraries will incorrectly reuse the client after the disconnected callback has fired which lead to this state and left the user wondering what had gone wrong.
I cleaned up the logging a bit so it will be more obvious what has gone wrong to developers.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: