Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Bluetooth reconnects from blocking shutdown #104150

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 17, 2023

Proposed change

If a device tried to make a connection after all the Bluetooth scanners were already shutdown, it would wait in a loop for a scanner to become available before raising a BleakError. We now raise right away if the Bluetooth manager has been shutdown

This turned out to be more common than one would immediately expect as what happens is that the integration gets a callback that the Bluetooth device has been disconnected as a result of HA shutdown, but it does not know that HA is shutting down so it tries to re-establish the connection and shutdown waits for the task which will never be successful because all the scanners are already shutdown

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bdraco J. Nick Koston
If a device tried to make a connection after all the
Bluetooth scanners were already shutdown, it would
wait in a loop for a scanner to become available
before raising a BleakError. We now raise right
away if the Bluetooth manager has been shutdown

This turned out to be more common than one would
immediately expect as what happens is that the integration
gets a callback that the Bluetooth device has been disconnected
as a result of HA shutdown, but it does not know that HA
is shutting down so it tries to re-establish the connection
and shutdown waits for the task which will never
be successful because all the scanners are already shutdown
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2023

thanks

@bdraco bdraco merged commit d3b4dd2 into dev Nov 19, 2023
@bdraco bdraco deleted the bluetooth_blocking_shutdown branch November 19, 2023 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants