Prevent Bluetooth reconnects from blocking shutdown #104150
Merged
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
If a device tried to make a connection after all the Bluetooth scanners were already shutdown, it would wait in a loop for a scanner to become available before raising a BleakError. We now raise right away if the Bluetooth manager has been shutdown
This turned out to be more common than one would immediately expect as what happens is that the integration gets a callback that the Bluetooth device has been disconnected as a result of HA shutdown, but it does not know that HA is shutting down so it tries to re-establish the connection and shutdown waits for the task which will never be successful because all the scanners are already shutdown
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: