-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Lidarr health binary sensor #108591
base: dev
Are you sure you want to change the base?
Conversation
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
I thinks there is still hope for this to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Please fix the CI failures (including documenting the binary sensor at https://www.home-assistant.io/integrations/lidarr/) and address the review comments though 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
And this is the PR for the documentation: home-assistant/home-assistant.io#32555 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lidarr
tests are failing, please fix them.
Also, since lidarr
already has tests, this PR should add tests also for the added binary sensor.
To run tests locally:
pytest homeassistant/components/lidarr
Proposed change
I want to create a page with all the health of all my services and the lidarr component was not providing it. here we go!
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: