Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lidarr health binary sensor #108591

Draft
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

denics
Copy link
Contributor

@denics denics commented Jan 21, 2024

Proposed change

I want to create a page with all the health of all my services and the lidarr component was not providing it. here we go!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (lidarr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lidarr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lidarr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title added support for Lidarr health binary sensor Add support for Lidarr health binary sensor Jan 21, 2024
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Mar 21, 2024
@denics
Copy link
Contributor Author

denics commented Mar 25, 2024

I thinks there is still hope for this to pass

@github-actions github-actions bot removed the stale label Mar 25, 2024
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

Please fix the CI failures (including documenting the binary sensor at https://www.home-assistant.io/integrations/lidarr/) and address the review comments though 👍

homeassistant/components/lidarr/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/lidarr/manifest.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 22, 2024 14:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@denics denics marked this pull request as ready for review May 1, 2024 16:37
@home-assistant home-assistant bot requested a review from emontnemery May 1, 2024 16:37
@denics
Copy link
Contributor Author

denics commented May 1, 2024

And this is the PR for the documentation: home-assistant/home-assistant.io#32555

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lidarr tests are failing, please fix them.
Also, since lidarr already has tests, this PR should add tests also for the added binary sensor.

To run tests locally:
pytest homeassistant/components/lidarr

@home-assistant home-assistant bot marked this pull request as draft May 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants