-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options flow to the airq integration #109337
Add options flow to the airq integration #109337
Conversation
Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but the PR needs to be rebased.
Expose to the user the following configuration: 1. A choice between fetching from the device either: a. the averaged (previous and the new default behaviour) or b. noisy momentary sensor reading 2. A toggle to clip (spuriously) negative sensor values (default functionality, previously unexposed) To those ends: - Introduce an `OptionsFlowHandler` alongside with a listener `AirQCoordinator.async_set_options` - Introduce constants to handle represent options - Add tests and strings
Modify `AirQCoordinator.__init__` to accommodate the change in option handling, and drop `async_set_options` which slipped through the previous commit.
aa9a1fd
to
8262bae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Sibgatulin 👍
Another iteration of a previous PR, which needed to be split.
Proposed change
Expose to the user the following configuration:
To those ends:
OptionsFlowHandler
alongside with a listenerAirQCoordinator.async_set_options
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: