Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.9.4 #110730

Merged
merged 9 commits into from
Apr 11, 2024
Merged

Bump aiohttp to 3.9.4 #110730

merged 9 commits into from
Apr 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 16, 2024

Proposed change

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This is rc0 for now but will be updated when the full release it out
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Feb 16, 2024
@bdraco
Copy link
Member Author

bdraco commented Apr 11, 2024

The websocket test failures are fine, they need to change the code.

The file upload ones need to be investigated

@bdraco
Copy link
Member Author

bdraco commented Apr 11, 2024

I did manually verify file upload works so it might be that file uploading now writes in the executor instead of doing blocking I/O in the event loop that cause the test to fail 🤞

@bdraco bdraco marked this pull request as ready for review April 11, 2024 20:47
@bdraco bdraco requested a review from a team as a code owner April 11, 2024 20:47
@bdraco
Copy link
Member Author

bdraco commented Apr 11, 2024

reran because of flakey influxdb test. I've attempted to fix it in #115442

@bdraco
Copy link
Member Author

bdraco commented Apr 11, 2024

Thanks

@bdraco bdraco merged commit 137514e into dev Apr 11, 2024
38 checks passed
@bdraco bdraco deleted the aiohttp_394 branch April 11, 2024 21:58
@frenck frenck added this to the 2024.4.3 milestone Apr 12, 2024
frenck pushed a commit that referenced this pull request Apr 12, 2024
* Bump aiohttp to 3.9.4

This is rc0 for now but will be updated when the full release it out

* cleanup cruft

* regen

* fix tests (these changes are fine)

* chunk size is too small to read since boundry is now enforced

* chunk size is too small to read since boundry is now enforced
@frenck frenck mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants