Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return group unit of measurement when device_class is None #110973

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

PoppyPop
Copy link
Contributor

@PoppyPop PoppyPop commented Feb 19, 2024

Proposed change

Allows to return calculated unit of measurement if no device class and all source sensors are same unit of measurement.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of group can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign group Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title Groups: Return units when device_class is None Return group unit when device_class is None Feb 19, 2024
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a bugfix as it's working as intended which I mentioned in the issue but I think it's a relevant change to add this in 👍

@home-assistant home-assistant bot marked this pull request as draft February 21, 2024 12:01
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@gjohansson-ST gjohansson-ST changed the title Return group unit when device_class is None Return group unit of measurement when device_class is None Feb 24, 2024
@gjohansson-ST gjohansson-ST added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Feb 24, 2024
@gjohansson-ST
Copy link
Member

As I have made all the relevant changes on this PR, another core developer should make the review 👍

@gjohansson-ST gjohansson-ST marked this pull request as ready for review February 24, 2024 09:58
@gjohansson-ST gjohansson-ST added this to the 2024.2.4 milestone Feb 24, 2024
@PoppyPop
Copy link
Contributor Author

PoppyPop commented Feb 25, 2024

Hello, sorry for the late reply, i wasn't at home, but i agree, your changes was most elegant that my quick changes

@balloob balloob merged commit 4a128f1 into home-assistant:dev Feb 26, 2024
53 checks passed
balloob pushed a commit that referenced this pull request Feb 26, 2024
* Groups: Return units when device_class is None

* Fixes

* Mods

---------

Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@balloob balloob mentioned this pull request Feb 26, 2024
@MartinHjelmare MartinHjelmare removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Feb 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit of measurements is not correct
4 participants