-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return group unit of measurement when device_class is None #110973
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a bugfix as it's working as intended which I mentioned in the issue but I think it's a relevant change to add this in 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
As I have made all the relevant changes on this PR, another core developer should make the review 👍 |
Hello, sorry for the late reply, i wasn't at home, but i agree, your changes was most elegant that my quick changes |
* Groups: Return units when device_class is None * Fixes * Mods --------- Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Proposed change
Allows to return calculated unit of measurement if no device class and all source sensors are same unit of measurement.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: