Use integration fallback configuration for tado water heater fallback #111014

ethemcemozkan · 2024-02-20T13:55:52Z

Proposed change

Unlike the climate entity where fallback was chosen based on the integration configuration, the existing fallback logic for the Tado water heater always used the NEXT_TIME option.
This PR changes fallback logic so that the value from the integration configuration is used.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Tado water heater always uses the smart schedule #103619
This PR is related to issue:
Link to documentation pull request: https://www.home-assistant.io/integrations/tado

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant

Hi @ethemcemozkan

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2024-02-20T13:55:56Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant · 2024-02-20T13:55:59Z

Hey there @chiefdragon, @erwindouna, mind taking a look at this pull request as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tado can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign tado Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Stale

homeassistant/components/tado/water_heater.py

homeassistant/components/tado/__init__.py

Orhideous

It's much better now. It would have been nice to have someone else look at it, but, in general, LGTM.

homeassistant/components/tado/climate.py

tests/components/tado/test_overlay_mode.py

Co-authored-by: Andriy Kushnir <me@orhideous.name>

homeassistant/components/tado/__init__.py

tests/components/tado/util.py

…efault

erwindouna

Also, don't forget to remove the brackets. Should simply the code a bit.

homeassistant/components/tado/__init__.py

github-actions · 2024-04-27T15:04:33Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

ethemcemozkan · 2024-05-01T18:44:08Z

still needed

emontnemery

Implementation looks good to me, just some minor comments which need to be addressed 👍

emontnemery · 2024-05-08T14:45:40Z

tests/components/tado/test_overlay_mode.py

We want tests of functionality to be in a module which matches the name of the module containing the functionality.
Either move these tests to test_init.py, or move the overlay helper function to a module named overlay_mode.py.

My own preference would be to move the overlay helper function to a module helper.py or util.py and tests in test_helper.py or test_util.py

emontnemery · 2024-05-08T14:48:01Z

tests/components/tado/util.py

@@ -165,3 +165,8 @@ async def async_init_integration(
        if not skip_setup:
            await hass.config_entries.async_setup(entry.entry_id)
            await hass.async_block_till_done()
+
+
+def dummy_tado_connector(hass: HomeAssistant, fallback) -> HomeAssistant:


The return type annotation is incorrect.

Also, I'd suggest to move this function to the test module to make the code easier to read.

erwindouna

Looks good to me now, thanks @ethemcemozkan!

emontnemery

LGTM, thanks @ethemcemozkan 👍

103619 tado water heater fallback

8bfb450

home-assistant bot added bugfix cla-needed integration: tado small-pr PRs with less than 30 lines. labels Feb 20, 2024

home-assistant bot previously requested changes Feb 20, 2024

View reviewed changes

home-assistant bot marked this pull request as draft February 20, 2024 13:55

home-assistant bot added Quality Scale: No score cla-recheck cla-signed and removed cla-recheck cla-needed labels Feb 20, 2024

ethemcemozkan changed the title ~~103619 tado water heater fallback~~ Use integration fallback configuration for tado water heater fallback Feb 20, 2024

Merge branch 'dev' into 103619-water-heater-default

2d6e2f3

ethemcemozkan marked this pull request as ready for review February 20, 2024 14:08

Orhideous reviewed Feb 21, 2024

View reviewed changes

homeassistant/components/tado/water_heater.py Outdated Show resolved Hide resolved

extracted a method to remove code duplication

1ee45d8

ethemcemozkan requested a review from Orhideous February 22, 2024 08:46

Orhideous suggested changes Feb 22, 2024

View reviewed changes

homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved

homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved

ethemcemozkan added 2 commits February 22, 2024 14:21

test cases and suggested changes

b3bcf4f

tests

2a966dc

ethemcemozkan requested a review from Orhideous February 22, 2024 14:24

Orhideous approved these changes Feb 22, 2024

View reviewed changes

homeassistant/components/tado/climate.py Outdated Show resolved Hide resolved

tests/components/tado/test_overlay_mode.py Outdated Show resolved Hide resolved

ethemcemozkan and others added 3 commits February 22, 2024 16:12

util method for connector

c706fce

Update homeassistant/components/tado/climate.py

ada2dbf

Co-authored-by: Andriy Kushnir <me@orhideous.name>

missing import after applies suggestion

d0edc29

erwindouna suggested changes Feb 26, 2024

View reviewed changes

homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved

tests/components/tado/util.py Outdated Show resolved Hide resolved

ethemcemozkan added 2 commits February 27, 2024 08:16

early return

eb81af5

Merge remote-tracking branch 'origin/HEAD' into 103619-water-heater-d…

81242ba

…efault

erwindouna suggested changes Feb 27, 2024

View reviewed changes

simplify if statements

0f72ddc

erwindouna suggested changes Feb 27, 2024

View reviewed changes

homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved

homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved

homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved

simplify pr

3ca4a27

erwindouna approved these changes Feb 27, 2024

View reviewed changes

Merge branch 'dev' into 103619-water-heater-default

908710f

github-actions bot added the stale label Apr 27, 2024

Merge branch 'dev' into 103619-water-heater-default

e443af0

github-actions bot removed the stale label May 1, 2024

emontnemery requested changes May 8, 2024

View reviewed changes

home-assistant bot marked this pull request as draft May 8, 2024 14:48

ethemcemozkan and others added 3 commits May 13, 2024 20:07

pr requested changes

4595826

Merge branch 'dev' into 103619-water-heater-default

8ffbd5a

better docstring

09694ec

ethemcemozkan requested a review from emontnemery May 13, 2024 20:38

ethemcemozkan marked this pull request as ready for review May 13, 2024 20:38

home-assistant bot requested review from Orhideous and erwindouna May 13, 2024 20:38

erwindouna approved these changes May 14, 2024

View reviewed changes

emontnemery approved these changes May 14, 2024

View reviewed changes

emontnemery merged commit b684801 into home-assistant:dev May 14, 2024
24 checks passed

github-actions bot locked and limited conversation to collaborators May 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use integration fallback configuration for tado water heater fallback #111014

Use integration fallback configuration for tado water heater fallback #111014

ethemcemozkan commented Feb 20, 2024 •

edited

home-assistant bot left a comment

home-assistant bot commented Feb 20, 2024

home-assistant bot commented Feb 20, 2024

Orhideous left a comment

erwindouna left a comment

github-actions bot commented Apr 27, 2024

ethemcemozkan commented May 1, 2024

emontnemery left a comment

emontnemery May 8, 2024

ethemcemozkan May 13, 2024

emontnemery May 8, 2024

erwindouna left a comment

emontnemery left a comment

Use integration fallback configuration for tado water heater fallback #111014

Use integration fallback configuration for tado water heater fallback #111014

Conversation

ethemcemozkan commented Feb 20, 2024 • edited

Proposed change

Type of change

Additional information

Checklist

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot commented Feb 20, 2024

home-assistant bot commented Feb 20, 2024

Orhideous left a comment

Choose a reason for hiding this comment

erwindouna left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2024

ethemcemozkan commented May 1, 2024

emontnemery left a comment

Choose a reason for hiding this comment

emontnemery May 8, 2024

Choose a reason for hiding this comment

ethemcemozkan May 13, 2024

Choose a reason for hiding this comment

emontnemery May 8, 2024

Choose a reason for hiding this comment

erwindouna left a comment

Choose a reason for hiding this comment

emontnemery left a comment

Choose a reason for hiding this comment

ethemcemozkan commented Feb 20, 2024 •

edited