Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another name missing in wyoming getLogger #111390

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

llluis
Copy link
Contributor

@llluis llluis commented Feb 25, 2024

Breaking change

Proposed change

Simple bugfix to allow proper logging of the integration. Similar to #109282 (which was merged in 2024.2.0).
Modified one and added one additional (one time) debug log to help troubleshoot issues with discovery.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@home-assistant
Copy link

Hey there @balloob, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (wyoming) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wyoming can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wyoming Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@llluis llluis changed the title bugfix another wyoming getLogger bugfix another name missing in wyoming getLogger Feb 25, 2024
@llluis llluis force-pushed the bugfix-wyoming-logger branch from 3bec3f6 to 990d58f Compare February 25, 2024 16:36
@MartinHjelmare MartinHjelmare changed the title bugfix another name missing in wyoming getLogger Fix another name missing in wyoming getLogger Feb 25, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit d3c53a1 into home-assistant:dev Feb 25, 2024
23 checks passed
@MartinHjelmare MartinHjelmare added this to the 2024.2.4 milestone Feb 25, 2024
@llluis llluis deleted the bugfix-wyoming-logger branch February 25, 2024 21:40
TheNoim pushed a commit to TheNoim/homeassistant-core that referenced this pull request Feb 25, 2024
balloob pushed a commit that referenced this pull request Feb 26, 2024
bugfix wyoming getLogger
@balloob balloob mentioned this pull request Feb 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants