Add light platform to Linear garage door #111426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
IceBotYT
force-pushed
the
linear-light-platform
branch
from
ed06c04
to
fa96b4d
Compare
CFenner
reviewed
Feb 26, 2024
IceBotYT
force-pushed
the
linear-light-platform
branch
2 times, most recently
from
fa96b4d
to
80a8690
Compare
IceBotYT
force-pushed
the
linear-light-platform
branch
3 times, most recently
from
3aebdb3
to
1351464
Compare
joostlek
requested changes
Apr 23, 2024
Comment on lines
64
to
105
| patch( | ||
| "homeassistant.components.linear_garage_door.light.Linear.login", | ||
| return_value=True, | ||
| ), | ||
| patch( | ||
| "homeassistant.components.linear_garage_door.light.Linear.get_devices", | ||
| return_value=[ | ||
| { | ||
| "id": "test1", | ||
| "name": "Test Garage 1", | ||
| "subdevices": ["GDO", "Light"], | ||
| }, | ||
| { | ||
| "id": "test2", | ||
| "name": "Test Garage 2", | ||
| "subdevices": ["GDO", "Light"], | ||
| }, | ||
| ], | ||
| ), | ||
| patch( | ||
| "homeassistant.components.linear_garage_door.light.Linear.get_device_state", | ||
| side_effect=lambda id: { | ||
| "test1": { | ||
| "GDO": {"Open_B": "true", "Open_P": "100"}, | ||
| "Light": {"On_B": "true", "On_P": "100"}, | ||
| }, | ||
| "test2": { | ||
| "GDO": {"Open_B": "false", "Open_P": "0"}, | ||
| "Light": {"On_B": "true", "On_P": "100"}, | ||
| }, | ||
| "test3": { | ||
| "GDO": {"Open_B": "false", "Opening_P": "0"}, | ||
| "Light": {"On_B": "false", "On_P": "0"}, | ||
| }, | ||
| "test4": { | ||
| "GDO": {"Open_B": "true", "Opening_P": "100"}, | ||
| "Light": {"On_B": "true", "On_P": "100"}, | ||
| }, | ||
| }[id], | ||
| ), | ||
| patch( | ||
| "homeassistant.components.linear_garage_door.light.Linear.close", | ||
| return_value=True, | ||
| ), |
There was a problem hiding this comment.
Consider creating a broader patch, checkout analytics_insights or Epion
There was a problem hiding this comment.
Take a look at what I did with the patches, is that enough?
Edit: Just realized this makes the tests fail, reverting
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
IceBotYT
force-pushed
the
linear-light-platform
branch
from
f206e68
to
14dabbd
Compare
joostlek
reviewed
Apr 24, 2024
|
I do like the base entity, so if you can maybe open a separate PR to do that before we merge this PR, that'd be nice :) |
20 tasks
|
Done #116133 |
IceBotYT
force-pushed
the
linear-light-platform
branch
from
7e65e94
to
4aacf4c
Compare
joostlek
requested changes
Apr 27, 2024
joostlek
reviewed
Apr 29, 2024
emontnemery
changed the title
IceBotYT
force-pushed
the
linear-light-platform
branch
from
db0e87e
to
9efeb12
Compare
IceBotYT
force-pushed
the
linear-light-platform
branch
from
6e4dd9d
to
9d6530d
Compare
joostlek
requested changes
May 15, 2024
joostlek
approved these changes
May 15, 2024
aschmere
pushed a commit
to aschmere/hacore2
that referenced
this pull request
May 16, 2024
* Add light platform * Fix light test * Suggestions by CFenner * Fix tests * More fixes * Revert test changes * Undo base entity * Rebase * Fix to use base entity * Fix name * More fixes * Fix tests * Add translation key --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the light platform to Linear.
These are not separate lights, but only lights that are inside of garage door openers.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: