Clear the Hydrawise next_cycle sensor when the value is unknown #111971
Conversation
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: hydrawise
small-pr
|
Hey there @ptcryan, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| @@ -99,4 +97,4 @@ def _update_attrs(self) -> None: | |||
| if (next_run := self.zone.scheduled_runs.next_run) is not None: | |||
| self._attr_native_value = dt_util.as_utc(next_run.start_time) | |||
| else: | |||
| self._attr_native_value = datetime.max.replace(tzinfo=dt_util.UTC) | |||
| self._attr_native_value = None | |||
There was a problem hiding this comment.
I think that the change should be to make the sensor unavailable rather than unknown
There was a problem hiding this comment.
No, unavailable is a separate property. None is a perfectly valid value and converts to "unknown". See the test case.
There was a problem hiding this comment.
Check this discussion as I think it's equivalent to this. #104522 (comment)
There was a problem hiding this comment.
Oh, I misunderstood your original comment.
I don't think setting this to unavailable is correct.
https://developers.home-assistant.io/docs/core/entity#generic-properties says "Indicate if Home Assistant is able to read the state and control the underlying device."
In this case, we can read the sensor value just fine--it just doesn't have a value. That's equivalent to None, which equates to "unknown".
There was a problem hiding this comment.
Ok! I will leave it up to another member to determine this :)
There was a problem hiding this comment.
If you're not comfortable reviewing this, can you unassign yourself so someone else can review?
frenck
added
the
smash
|
I integrated this change into #116303 since we are already touching all the sensor code there. |
Proposed change
If the
next_cyclesensor value is unknown, we currently set it todatetime.max. Despite that being a constant value, it causes the sensor entities to update on every data refresh. (See #110054) Setting this toNonechanges the value to show as "unknown", which should prevent updates. (It's also arguably more correct)Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: