Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Freebox wifiguest devices #112666

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

slecache
Copy link

@slecache slecache commented Mar 8, 2024

Breaking change

Proposed change

Add the devices connected on the "wifi guest" of the Freebox. This will allow to have device tracker for guests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@slecache slecache requested a review from Quentame as a code owner March 8, 2024 01:11
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slecache

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Mar 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Mar 8, 2024

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign freebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@slecache slecache marked this pull request as ready for review March 8, 2024 18:59
@slecache slecache force-pushed the freebox-router-wifiguest branch 7 times, most recently from f791934 to 9e681ad Compare March 13, 2024 17:17
@slecache slecache force-pushed the freebox-router-wifiguest branch 4 times, most recently from 6b71e6a to e08c9e3 Compare March 22, 2024 21:31
@slecache slecache force-pushed the freebox-router-wifiguest branch 4 times, most recently from a86eb22 to 50b69b1 Compare April 5, 2024 21:19
tests/components/freebox/conftest.py Outdated Show resolved Hide resolved
@@ -72,7 +72,9 @@ async def get_hosts_list_if_supported(
supports_hosts: bool = True
fbx_devices: list[dict[str, Any]] = []
try:
fbx_devices = await fbx_api.lan.get_hosts_list() or []
fbx_devices_pub = await fbx_api.lan.get_hosts_list("pub") or []
fbx_devices_wifiguest = await fbx_api.lan.get_hosts_list("wifiguest") or []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is wifiguest always correct?
Should we set some flag so we know which device trackers are guests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to configure this value on the Freebox OS.
I got wifiguest value in the result of the following API request: GET /api/v4/lan/browser/interfaces/ (source)

Good point for the flag. But I don't know the best design practices for defining this flag in a device tracker.

Co-authored-by: Erik Montnemery <erik@montnemery.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants