-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Freebox wifiguest devices #112666
base: dev
Are you sure you want to change the base?
Add Freebox wifiguest devices #112666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
f791934
to
9e681ad
Compare
6b71e6a
to
e08c9e3
Compare
e08c9e3
to
eb841e5
Compare
a86eb22
to
50b69b1
Compare
50b69b1
to
3c801ca
Compare
3c801ca
to
2fb66e5
Compare
2fb66e5
to
bc01685
Compare
bc01685
to
ae69a0e
Compare
@@ -72,7 +72,9 @@ async def get_hosts_list_if_supported( | |||
supports_hosts: bool = True | |||
fbx_devices: list[dict[str, Any]] = [] | |||
try: | |||
fbx_devices = await fbx_api.lan.get_hosts_list() or [] | |||
fbx_devices_pub = await fbx_api.lan.get_hosts_list("pub") or [] | |||
fbx_devices_wifiguest = await fbx_api.lan.get_hosts_list("wifiguest") or [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is wifiguest
always correct?
Should we set some flag so we know which device trackers are guests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way to configure this value on the Freebox OS.
I got wifiguest
value in the result of the following API request: GET /api/v4/lan/browser/interfaces/
(source)
Good point for the flag. But I don't know the best design practices for defining this flag in a device tracker.
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Breaking change
Proposed change
Add the devices connected on the "wifi guest" of the Freebox. This will allow to have device tracker for guests.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: