-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Duotecno entities unavailable when tcp goes down #114325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks @Cereal2nd 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this does update the state only when the entity is created, which is probably what's wanted here?
i was just testing this, and no the state can be updated during the runtime, and it seems that this is not happening, so i think we still need the property |
Yes, either a property or setting it inside the update callback. I think both are fine, setting the variable directly saves a bit code and is generally preferred, but the original way you had is also fine. Your call! |
This reverts commit f26b4e6.
I just reverted my fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Cereal2nd! 👍
Proposed change
When the tcp connection to the duotecno smartbox goes down, mark all entities as unavailble.
This depends on #114320
Can we also add this to 2024.4.0? This will greatly improve the usability of duotecno.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: