Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for SwitchBot Meter, MeterPlus, and Outdoor Meter #115522

Merged
merged 21 commits into from
May 13, 2024

Conversation

laurence-presland
Copy link
Contributor

@laurence-presland laurence-presland commented Apr 13, 2024

Proposed change

This PR adds support for the SwitchBot Meter, MeterPlus, and Outdoor Meter devices within the SwitchBot Cloud integration.

It adds a temperature, battery, and humidity sensor entity for each discovered MeterPlus device. The scan interval is now exposed to the user on initial setup and defaults to 600.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I've also updated the update_interval depending on the device as sensor devices require more frequent polling.

New to this project and not a Python pro so let me know if there are improvements to make.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurencepresland,@PreslandBoy

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @SeraphicRav, mind taking a look at this pull request as it has been labeled with an integration (switchbot_cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot_cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot_cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurencepresland

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Add temperature, humidity, and battery sensor entities for the MeterPlus device
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurence-presland

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

laurence-presland and others added 3 commits April 13, 2024 22:27
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Concat entity ID in SwitchBotCloudSensor init
@laurence-presland laurence-presland marked this pull request as ready for review April 13, 2024 14:23
laurence-presland and others added 3 commits April 30, 2024 09:30
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@laurence-presland laurence-presland marked this pull request as ready for review May 9, 2024 12:55
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft May 9, 2024 13:00
@laurence-presland laurence-presland marked this pull request as ready for review May 9, 2024 13:40
@home-assistant home-assistant bot requested a review from joostlek May 9, 2024 13:40
@joostlek
Copy link
Member

Please open a PR for the docs

@joostlek
Copy link
Member

Oh never mind, I didn't completely scroll through

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run hassfest

@home-assistant home-assistant bot marked this pull request as draft May 10, 2024 08:51
@laurence-presland laurence-presland marked this pull request as ready for review May 13, 2024 12:20
@home-assistant home-assistant bot requested a review from joostlek May 13, 2024 12:20
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for this or add the sensor.py file to .coveragerc?

@joostlek joostlek dismissed edenhaus’s stale review May 13, 2024 13:18

Changes implemented

@joostlek joostlek merged commit c3f95a4 into home-assistant:dev May 13, 2024
23 of 24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants