-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for SwitchBot Meter, MeterPlus, and Outdoor Meter #115522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @laurencepresland,@PreslandBoy
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Hey there @SeraphicRav, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Add temperature, humidity, and battery sensor entities for the MeterPlus device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Concat entity ID in SwitchBotCloudSensor init
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing, can you take a look?
Please open a PR for the docs |
Oh never mind, I didn't completely scroll through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run hassfest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for this or add the sensor.py
file to .coveragerc
?
Proposed change
This PR adds support for the SwitchBot Meter, MeterPlus, and Outdoor Meter devices within the SwitchBot Cloud integration.
It adds a temperature, battery, and humidity sensor entity for each discovered MeterPlus device. The scan interval is now exposed to the user on initial setup and defaults to 600.
Type of change
Additional information
I've also updated the
update_interval
depending on the device as sensor devices require more frequent polling.New to this project and not a Python pro so let me know if there are improvements to make.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
Add Meter, MeterPlus, and Outdoor Meter to SwitchBot Cloud Docs home-assistant.io#32335
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: