Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jewish Calendar attributes for non-date sensors #116252

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SLaks
Copy link
Contributor

@SLaks SLaks commented Apr 26, 2024

  • Add attributes for individual date components.
    • This makes it possible to check information about the current date without trying to parse the string.
  • Mark holiday and parsha sensors as Enum.
    • This shows users a dropdown of valid values when using these sensors in a condition or trigger, which is much more convenient.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

 - Add attributes for individual date components.
   - This makes it possible to check information
     about the current date without trying to
     parse the string.
 - Mark holiday and parsha sensors as Enum.
   - This shows users a dropdown of valid values when
     using these sensors in a condition or trigger,
     which is much more convenient.
@home-assistant
Copy link

Hey there @tsvi, mind taking a look at this pull request as it has been labeled with an integration (jewish_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jewish_calendar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jewish_calendar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

2 things:

  1. The integration isn't using a config flow yet so we don't allow new features on them before it's migrated. I know there is a PR in the works, but that should be merged first.
  2. We generally don't want to add more state attributes. Please check if they can be separate entities or can be converted to a service call.

@joostlek joostlek marked this pull request as draft April 26, 2024 15:14
@SLaks
Copy link
Contributor Author

SLaks commented Apr 26, 2024

We generally don't want to add more state attributes

Why not / what guidelines are there?

It doesn't really make sense to have separate sensors for the year, month and day; these are only useful as separate components in conditions.

#111986 adds services that expose this information for arbitrary dates, but I think it makes sense to expose them directly for the current date. For example, it should be very easy to add an automation condition that checks the current month, without having to add a service call and templating.

@MartinHjelmare MartinHjelmare changed the title Jewish Calendar: Add attributes for non-date sensors: Add Jewish Calendar attributes for non-date sensors Apr 29, 2024
@tsvi tsvi mentioned this pull request Apr 29, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants