New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use websocket client to test device removal in Unifi #116309
Use websocket client to test device removal in Unifi #116309
Conversation
Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I cannot comment on PR #115267 any more, but have resolved the comment over there |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
674927d
to
3d4f3d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Thank you! |
Proposed change
Unit test cleanup:
use websocket client to test device removal from registry as per this review comment :
#115267 (comment)
The logic of the unit test is otherwise the same as previously.
Type of change
Additional information
Allow manual delete of stale Unifi device from UI #115267
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: