Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smart_meter_texas to 0.5.5 #116321

Merged
merged 5 commits into from Apr 30, 2024
Merged

Conversation

grahamwetzler
Copy link
Contributor

@grahamwetzler grahamwetzler commented Apr 28, 2024

Proposed change

Bumps smart_meter_texas to the latest version. This fixes an API authentication issue.

Here's the entire diff from v0.4.7 (the version that Home Assistant is using) to v0.5.5.

However, the actual fix for the authentication issue is here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link to the library changes

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 28, 2024 07:13
@bdraco bdraco added this to the 2024.5.0 milestone Apr 28, 2024
@grahamwetzler
Copy link
Contributor Author

Here's the entire diff from v0.4.7 (the version that Home Assistant is using) to v0.5.5.

However, the actual fix for the authentication issue is here

@grahamwetzler grahamwetzler marked this pull request as ready for review April 28, 2024 14:48
@home-assistant home-assistant bot requested a review from Kane610 April 28, 2024 14:48
@bdraco
Copy link
Member

bdraco commented Apr 28, 2024

Please add the library information to the opening text. Thanks

@bdraco
Copy link
Member

bdraco commented Apr 28, 2024

grahamwetzler/smart-meter-texas@v0.4.7...v0.5.5#diff-c83fef8f5af1e5f7768492b717f5577d749041fbb02d63f801cbc68c250bad71R417

Loading ssl certs from disk does blocking I/O. Is this running in the executor?

Looks like an existing problem though so it shouldn't hold up merging this PR

@frenck frenck dismissed Kane610’s stale review April 30, 2024 07:47

Comment addressed

@frenck frenck merged commit b777947 into home-assistant:dev Apr 30, 2024
38 checks passed
frenck pushed a commit that referenced this pull request Apr 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants