Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create auxHeatOnly switch in Ecobee integration #116323

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bjpetit
Copy link
Contributor

@bjpetit bjpetit commented Apr 28, 2024

Proposed change

Add switch entity for ecobee auxHeatOnly behavior. This follows the
prior behavior of the deprecated aux_heat services and aux_heat toggle.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jbouwh
jbouwh previously requested changes Apr 28, 2024
homeassistant/components/ecobee/climate.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 28, 2024 13:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

homeassistant/components/ecobee/repairs.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
tests/components/ecobee/test_notify.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 29, 2024 21:13
@bjpetit bjpetit force-pushed the ecobee-deprecate-aux-heat branch 4 times, most recently from 6456120 to 55168d3 Compare April 30, 2024 04:07
@bjpetit bjpetit marked this pull request as ready for review April 30, 2024 16:56
@bjpetit
Copy link
Contributor Author

bjpetit commented May 3, 2024

Need to sync up with latest ecobee commit. Moving back to draft.

@bjpetit bjpetit marked this pull request as draft May 3, 2024 13:06
@bjpetit bjpetit force-pushed the ecobee-deprecate-aux-heat branch from 55168d3 to 0f86a3f Compare May 3, 2024 16:43
@bjpetit bjpetit force-pushed the ecobee-deprecate-aux-heat branch from 0f86a3f to 6afc22e Compare May 3, 2024 16:50
@bjpetit
Copy link
Contributor Author

bjpetit commented May 3, 2024

I've rebased and refactored this switch based on the newly introduced switch code in this integration.

@bjpetit bjpetit marked this pull request as ready for review May 3, 2024 16:55
@bjpetit bjpetit force-pushed the ecobee-deprecate-aux-heat branch 2 times, most recently from a486c71 to cfc78d9 Compare May 4, 2024 17:34
@bjpetit bjpetit force-pushed the ecobee-deprecate-aux-heat branch from 8f25ede to 4b4a69d Compare May 13, 2024 18:14
@bjpetit bjpetit changed the title Deprecate aux_heat in Ecobee integration Create auxHeatOnly switch in Ecobee integration May 13, 2024
@bjpetit
Copy link
Contributor Author

bjpetit commented May 13, 2024

I've updated this PR to focus on implementing the Aux Heat switch in the ecobee integration.
It appears that there is already code in the Climate component (See #112532) which should raise an issue for the deprecation of the aux_heat state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants