New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact sensitive data in Plugwise diagnostics #116338
base: dev
Are you sure you want to change the base?
Conversation
Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
What's the main reason you want to hide this? I think this data is helpful with checking what device is problematic |
Hi Joost, the non-MAC-related parts often contain privacy-sensitive information like a persons name, that's why they are proposed to be redacted. But now that I think about this again, I would like to redact the separate schedule-names each, and show when the |
@joostlek The code was updated in such a way that all info us code-owners want to retain, while redacting the actual info, is still present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I agree with @joostlek here, I'm not sure what is sensitive here, especially looking at the zigbee addresses in this case.
Also there is some custom logic in here that does stuff with our general redaction (like adding a postfix **REDACTED_4**
).
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Redact sensitive data in Plugwise diagnostics.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: