Add reauth for missing token scope in Husqvarna Automower #117098
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thomas55555
changed the title
Thomas55555
changed the title
| translation_key="wrong_scope", | ||
| data={"entry_id": entry.entry_id}, | ||
| ) | ||
| entry.async_start_reauth(hass) |
There was a problem hiding this comment.
We can raise ConfigEntryAuthFailed.
There was a problem hiding this comment.
Wouldn't that be to restrictive? Because in this case the integration would fail to setup. But the integration would still work without that token scope, only some functions won't.
There was a problem hiding this comment.
Ok. Then please add a code comment here explaining why we don't raise.
There was a problem hiding this comment.
I'm reading the linked issue and it seems not having the websocket will create unexpected behavior and problems. Why should we allow to use the integration without the websocket?
There was a problem hiding this comment.
I thought it's better for the user. If the user updates its HA instance, the the integration is more or less broken, until he finds time to reauthenticate. And so he can at least use the integration with polling every 8 minutes. But if you think it's better to raise ConfigEntryAuthFailed we can do so.
There was a problem hiding this comment.
I think it's better to have things behave predictably. The docs say you should activate both APIs, so most users will probably have done that already.
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Thomas55555
deleted the
Add-repair-for-wrong-token-scope-to-Husqvarna-Automower
branch
Breaking change
Proposed change
Authentication APIand theAutomower Connect API. If they only connect to theAuthentication APIonly polling works but the websockets connection can't be established. Maybe it's also related that some users can't send commands to their device.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: