New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the mqtt discovery update tasks eager and fix race #117105
Conversation
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
if self._discovery_data is not None: | ||
send_discovery_done(self.hass, self._discovery_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug here is that we were sending the discovery done before the state was written in add_to_platform_finish
@@ -1218,8 +1225,6 @@ async def async_added_to_hass(self) -> None: | |||
self._prepare_subscribe_topics() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This never actually yields to the loop so it runs synchronously when the entity is being added.
The test only passed because the task was started non-eagerly even though we called send_discovery_done
too soon. As soon as it started eagerly it was now much more obvious that the state was not being written in time.
Thanks! |
Proposed change
This PR:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: