-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add services for Husqvarna Automower #117269
base: dev
Are you sure you want to change the base?
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
} | ||
}, | ||
"start_for": { | ||
"name": "Start for", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Start for" doesn't sound good. Maybe "Mow for"?
Also, consider a common service which allows overriding the schedule for a certain duration, where the mode is set to mow or park.
number: | ||
min: 1 | ||
max: 60480 | ||
unit_of_measurement: "min" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A maximum of 60480 minutes is a bit ridiculous, it's 42 days.
Why not a duration selector?
Breaking change
Proposed change
Add two services, to let the device start for a period of time or park for or period of time. This overrides the schedule.
As an alternative I thought about a number entity instead. But as we don't get any information from the API for this overrides, the state would always be
None
which is not allowed for this platform.I will add the documentation if the reviews are okay.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: