Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaraco.abode to 5.1.2 #117363

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jaraco
Copy link

@jaraco jaraco commented May 13, 2024

  • Bump the dependency on jaraco.abode.
  • Replace constants with their literal values.

Closes #115561

See jaraco.abode history for changes between 3.3.0 and 5.1.2.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • (N/A) Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jaraco

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 14:03
@home-assistant
Copy link

Hey there @shred86, mind taking a look at this pull request as it has been labeled with an integration (abode) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of abode can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign abode Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek changed the title Update abode component for jaraco.abode 5 Bump jaraco.abode to 5 May 13, 2024
@jaraco
Copy link
Author

jaraco commented May 13, 2024

That's interesting that ruff is failing. I made these changes using an editor with ruff configured for "format on save", so I'm surprised that didn't maintain the format expectation.

Oh, I see now, my editor wasn't formatting due to running an old version.

image

@jaraco
Copy link
Author

jaraco commented May 13, 2024

Hmm. Ruff 0.3.7 is only a month old, so it's not really a bug in my editor that it hasn't downloaded the bleeding edge release. I'll just format manually.

@jaraco jaraco force-pushed the feature/115561-bump-abode branch from d7af67b to 1707336 Compare May 13, 2024 15:58
@jaraco jaraco force-pushed the feature/115561-bump-abode branch from 1707336 to 26daea8 Compare May 13, 2024 15:58
@jaraco
Copy link
Author

jaraco commented May 13, 2024

I'm leaving the codeowner unchanged for now. Maybe it makes sense to make me codeowner, but I'm not sure about that. I'd prefer for someone with homeassistant+abode to be the owner. That may be me some day, or I may accept that responsibility, but it seems out of the scope of this change.

@jaraco jaraco marked this pull request as ready for review May 13, 2024 16:24
@joostlek
Copy link
Member

I mean, massive thanks for helping out :)

@joostlek
Copy link
Member

If you could maybe take a look at the open issues (and maybe checkout some issues that got closed because they got stale) and maybe give an opinion on where the issue lies, that'd be awesome. If time allows me (because thesis deadline is getting close) I am happy to help out with the integration at the HA side.

If you use discord, feel free to send me a message, would love to stay in contact :)

@jaraco jaraco mentioned this pull request May 13, 2024
@epenet epenet changed the title Bump jaraco.abode to 5 Bump jaraco.abode to 5.1.2 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to update to latest jaraco.abode
2 participants