Add tado climate swings and fan level #117378
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
|
Hey there @chiefdragon, @erwindouna, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
MartinHjelmare
changed the title
| @@ -81,7 +81,7 @@ async def test_smartac_with_swing(hass: HomeAssistant) -> None: | |||
| "min_temp": 16.0, | |||
| "preset_mode": "auto", | |||
| "preset_modes": ["away", "home", "auto"], | |||
| "swing_modes": ["on", "off"], | |||
| "swing_modes": ["off", "on"], | |||
There was a problem hiding this comment.
Why is this order reversed and what does it do?
There was a problem hiding this comment.
It's because I changed the order of insertion in swing_modes.
I can reverse it. My bad.
| if self.supported_features & ClimateEntityFeature.SWING_MODE: | ||
| swing = self._current_tado_swing_mode | ||
| if self._attr_swing_modes is not None: |
There was a problem hiding this comment.
Can we reduce the nesting here? Can an early-return principle be used here?
There was a problem hiding this comment.
Yes you're right. I think I can merge it in a single if.
I don't think I can use a return because I don't want to skip the call to set_zone_overlay for that reason.
There was a problem hiding this comment.
Feel free to let me know when you committed these changes and I need to review them again.
There was a problem hiding this comment.
It's okay. Let me know if you want some other changes.
|
No idea how I broke that test. |
|
This test is also broken on the dev branch. So, I don't know how to fix it. |
Breaking change
Proposed change
Fix tado integration to handle fanLevel, verticalSwing and horizontalSwing
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: