Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move environment_canada coordinator to separate module #117426

Merged
merged 4 commits into from
May 20, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 14, 2024

Proposed change

SSIA, linked to #108174

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gwww, @michaeldavie, mind taking a look at this pull request as it has been labeled with an integration (environment_canada) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of environment_canada can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign environment_canada Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gwww
Copy link
Contributor

gwww commented May 14, 2024

Curious why this change. I’m assuming some architecture decision?

@epenet
Copy link
Contributor Author

epenet commented May 14, 2024

Curious why this change. I’m assuming some architecture decision?

See #108174

@frenck

This comment was marked as resolved.

@epenet

This comment was marked as resolved.

@frenck

This comment was marked as resolved.

@epenet epenet marked this pull request as draft May 14, 2024 12:20
@epenet

This comment was marked as resolved.

@epenet
Copy link
Contributor Author

epenet commented May 14, 2024

Note: coverage isn't really affected by this change. The lines that are not covered were already not covered previously.

Copy link
Contributor

@gwww gwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly extra imports in terms of what I can see. I will have to test later.

@epenet epenet marked this pull request as ready for review May 14, 2024 20:39
@gwww
Copy link
Contributor

gwww commented May 19, 2024

I just tested this out. Works fine!

@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label May 19, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

../Frenck

@frenck frenck merged commit 3f15b44 into home-assistant:dev May 20, 2024
23 of 24 checks passed
@epenet epenet deleted the 20240514-1340 branch May 20, 2024 08:00
bajansen pushed a commit to bajansen/homeassistant that referenced this pull request May 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants