-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add water meter to Youless intergration #117452
Conversation
Hey there @gjong, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does two things.
- It bumps the dependencies.
- It adds a new features.
Those should be split out into separate PRs (as pointed out by the PR template you filled out as well).
See also: https://developers.home-assistant.io/docs/review-process#creating-the-perfect-pr
Thanks! 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Addition of a Water meter device to the Youless Integration. See home-assistant/core#117452
You are right. Sorry. I removed the updated dependencies and put them in a seperate PR at #117459 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @benvm 👍
../Frenck
PS: As a good next step for this integration, might be adding entity translations and icon translation (removing them from the code).
Proposed change
This adds a Water meter device to the Youless Integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: