Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water meter to Youless intergration #117452

Merged
merged 3 commits into from
May 14, 2024

Conversation

benvm
Copy link
Contributor

@benvm benvm commented May 14, 2024

Proposed change

This adds a Water meter device to the Youless Integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gjong, mind taking a look at this pull request as it has been labeled with an integration (youless) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of youless can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign youless Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does two things.

  1. It bumps the dependencies.
  2. It adds a new features.

Those should be split out into separate PRs (as pointed out by the PR template you filled out as well).

See also: https://developers.home-assistant.io/docs/review-process#creating-the-perfect-pr

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 14, 2024 17:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

benvm added a commit to benvm/home-assistant.io that referenced this pull request May 14, 2024
Addition of a Water meter device to the Youless Integration.
See home-assistant/core#117452
@benvm benvm mentioned this pull request May 14, 2024
20 tasks
@benvm
Copy link
Contributor Author

benvm commented May 14, 2024

You are right. Sorry.

I removed the updated dependencies and put them in a seperate PR at #117459

@benvm benvm requested a review from frenck May 14, 2024 19:38
@frenck frenck marked this pull request as ready for review May 14, 2024 19:43
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @benvm 👍

../Frenck

PS: As a good next step for this integration, might be adding entity translations and icon translation (removing them from the code).

@frenck frenck merged commit dad9423 into home-assistant:dev May 14, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants