New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix humidifier state error in HomeKit #61432
Fix humidifier state error in HomeKit #61432
Conversation
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
This PR is awaiting ikalchev/HAP-python@626c033 being included into HA Core, and then can be merged to actually address the error. |
This should be good to rebase once #60220 merges |
d3f10df
to
913526a
Compare
Done! |
If this is ready for review, please mark it ready for review. It would be good to get a test for this as well |
913526a
to
0d6e90a
Compare
Proposed change
The default value of
TargetHumidifierDehumidifierState
inpyhap
is 0, which stands for "HumidifierorDehumidifier", while thevalid_values
in HomeKit integration only supplies either 1 or 2 for it, leading to the error.See here:
https://github.com/ikalchev/HAP-python/blob/bc5ecbf6701a3aefba7d9a7abadb28cbf233f451/pyhap/resources/characteristics.json#L1429-L1442
Edited: This PR is awaiting ikalchev/HAP-python@626c033 being included into HA Core, and then can be merged to actually address the error.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: