Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure august status is current when integration loads #64027

Merged
merged 4 commits into from Jan 13, 2022
Merged

Ensure august status is current when integration loads #64027

merged 4 commits into from Jan 13, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 13, 2022 •
edited

Proposed change

Ensure august status is current when integration loads

Since there may be no pubnub subscribers, the status
may be stale at startup. We now query for the query status
from the lock when the integration is loaded.

Changelog: bdraco/yalexs@v1.1.17...v1.1.18

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Ensure august status is current when integration loads
d9d7c24 
- The status may be stale from the august api when
  we fetch the state after restarting since there
  were no pubnub listeners. A status refresh is now
  requested when the integration is loaded
@bdraco
update test
92de4c5
@bdraco
ensure its called
fe590f4
@bdraco
ensure its called
4d663db
@project-bot project-bot bot added this to Needs review in Dev Jan 13, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 13, 2022
Dev automation moved this from By Code Owner to Reviewer approved Jan 13, 2022
@frenck frenck merged commit 06fd75b into home-assistant:dev Jan 13, 2022
Dev automation moved this from Reviewer approved to Done Jan 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
@balloob balloob added this to the 2021.12.10 milestone Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@ctalkington ctalkington ctalkington approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed has-tests integration: august small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
2021.12.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bdraco @frenck @ctalkington @balloob @homeassistant