Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unavailable entities when creating zwave_js device actions list #64184

Merged
merged 4 commits into from Jan 16, 2022

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Jan 16, 2022

Proposed change

We should not try to generate device actions for unavailable entities since they may no longer be backed by a valid Z-Wave Value. This PR fixes that and fixes #63331 where this issue was originally reported

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jan 16, 2022
@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@raman325 raman325 marked this pull request as ready for review January 16, 2022 05:54
@raman325 raman325 requested a review from a team as a code owner January 16, 2022 05:54
@raman325 raman325 added this to the 2021.12.10 milestone Jan 16, 2022
@raman325 raman325 changed the title Fix bug with zwave-js device actions Ignore unavailable entities when generating zwave_js device actions list Jan 16, 2022
@raman325 raman325 changed the title Ignore unavailable entities when generating zwave_js device actions list Ignore unavailable entities when creating zwave_js device actions list Jan 16, 2022
@raman325
Copy link
Contributor Author

raman325 commented Jan 16, 2022

I'm wondering if this is the right way to handle this or if we should instead check if the value_id exists on the node and continue the loop if not

Dev automation moved this from Needs review to Reviewer approved Jan 16, 2022
@balloob
Copy link
Member

balloob commented Jan 16, 2022

@raman325 Both entity and value should represent the same data. Hitting the value_id would give you 100% certainty I guess. However, I assume the action is operating on the entity?

@raman325
Copy link
Contributor Author

@raman325 Both entity and value should represent the same data. Hitting the value_id would give you 100% certainty I guess. However, I assume the action is operating on the entity?

Yes thats correct. I think I overthought this, this is a fine approach

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 9bb78af into home-assistant:dev Jan 16, 2022
Dev automation moved this from Reviewer approved to Done Jan 16, 2022
@raman325 raman325 deleted the fix_device_action branch January 16, 2022 20:18
balloob pushed a commit that referenced this pull request Jan 17, 2022
#64184)

* Fix bug with zwave-js device actions

* outdent

* Add test and fix bug

* fix
@balloob balloob mentioned this pull request Jan 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Unknown action on most zwave JS devices in automation
4 participants