New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore unavailable entities when creating zwave_js device actions list #64184
Ignore unavailable entities when creating zwave_js device actions list #64184
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
I'm wondering if this is the right way to handle this or if we should instead check if the value_id exists on the node and |
@raman325 Both entity and value should represent the same data. Hitting the value_id would give you 100% certainty I guess. However, I assume the action is operating on the entity? |
Yes thats correct. I think I overthought this, this is a fine approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
#64184) * Fix bug with zwave-js device actions * outdent * Add test and fix bug * fix
Proposed change
We should not try to generate device actions for unavailable entities since they may no longer be backed by a valid Z-Wave Value. This PR fixes that and fixes #63331 where this issue was originally reported
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: