Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bluetooth recovers if Dbus gets restarted #76249

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 4, 2022

Until this merging, manually reloading the bluetooth integration should work around the issue.

Proposed change

If Dbus gets restarted out from under us everything will fail to connect with Method "Connect" with signature "" on interface "org.bluez.Device1" doesn't exist because the devices will no longer be available on the bus. We need to restart the scanner so it reconnects the devices to the bus if everything has gone quiet.

This should fix the issues were users reporting bluetooth stops working overnight when the host installs updates and restarts services.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review August 4, 2022 21:47
Dev automation moved this from Needs review to Reviewer approved Aug 7, 2022
@balloob balloob merged commit 1fe44d0 into home-assistant:dev Aug 7, 2022
Dev automation moved this from Reviewer approved to Done Aug 7, 2022
@balloob balloob mentioned this pull request Aug 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Switchbot integration does not work with grouped curtains Switchbot communication failed
3 participants