Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiobafi6 to 0.7.2 to unblock #76328 #76330

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

jfroy
Copy link
Contributor

@jfroy jfroy commented Aug 5, 2022

Proposed change

Bump aiobafi6 to 0.7.2 to unblock #76328.

Dep changelog: jfroy/aiobafi6@0.7.0...0.7.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (baf) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bdraco bdraco closed this Aug 5, 2022
@bdraco bdraco reopened this Aug 5, 2022
@bdraco
Copy link
Member

bdraco commented Aug 5, 2022

Close/reopen to restart Ci

@bdraco
Copy link
Member

bdraco commented Aug 5, 2022

The unpin appears to be letting the dep float back up which uncovers some previously hidden conflicts. I think the right fix is to bump the number up and let the libs that are pinning it get fixed

@bdraco
Copy link
Member

bdraco commented Aug 5, 2022

I asked internally about aioesphomeapi and opened googleapis/python-texttospeech#314

@jfroy jfroy changed the title Bump aiobafi6 to 0.7.1 to unblock #76328 Bump aiobafi6 to 0.7.2 to unblock #76328 Aug 5, 2022
@bdraco bdraco closed this Aug 5, 2022
@bdraco bdraco reopened this Aug 5, 2022
@bdraco
Copy link
Member

bdraco commented Aug 5, 2022

Close reopen to restart CI

@bdraco
Copy link
Member

bdraco commented Aug 5, 2022

pychromecast 12.1.4 has requirement protobuf<4,>=3.19.1, but you have protobuf 4.21.4.
hangups 0.4.18 has requirement protobuf<4,>=3.1.0, but you have protobuf 4.21.4.

These are issues as well

@bdraco bdraco added this to the 2022.8.2 milestone Aug 6, 2022
@bdraco
Copy link
Member

bdraco commented Aug 6, 2022

Tagging this for .2 so if we have to cherry pick the zeroconf fix I'm working, the build won't break

@bdraco
Copy link
Member

bdraco commented Aug 6, 2022

Thanks @jfroy

@bdraco bdraco merged commit 7c6a64c into home-assistant:dev Aug 6, 2022
@jfroy jfroy deleted the bump-aiobafi6 branch August 6, 2022 01:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants