Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging for unknown Notion errors #76395

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Aug 7, 2022

Proposed change

Per #76394, Notion sometimes gets an unknown error during coordinator update, and the message alone isn't enough to determine what it is. This PR adds the corresponding traceback as a DEBUG-level log so that we can investigate further.

I also removed a constant in the same file that wasn't used anywhere.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 2022.8.2 milestone Aug 7, 2022
@bachya bachya self-assigned this Aug 7, 2022
@bachya bachya modified the milestones: 2022.8.2, 2022.8.3 Aug 7, 2022
@bachya bachya merged commit dc30d97 into home-assistant:dev Aug 7, 2022
@bachya bachya deleted the notion-broad-error-discovery branch August 7, 2022 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants