Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google calendar disabled entity handling #76699

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

allenporter
Copy link
Contributor

Proposed change

Fix google calendar disabled entity handling by waiting to poll the entity until it has been added to home assistant, rather than before it is added.

I noticed that Google Calendar was taking a long time to start when loading my corporate calendar which is massive. I first attempted to make all the coordinator loads happen in parallel which helped. Then I disabled the entity since i'm not using it and noticed it still was being loaded. I realized the right fix is to defer the fetching until adding the entity so that the disabled bit is respected, rather than just making the existing calls happen in parallel. This copies what the flume integration does.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 12, 2022
Dev automation moved this from Needs review to Reviewer approved Aug 13, 2022
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thnx

@jbouwh jbouwh added this to the 2022.8.5 milestone Aug 13, 2022
@jbouwh jbouwh merged commit b969ed0 into home-assistant:dev Aug 13, 2022
Dev automation moved this from Reviewer approved to Done Aug 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants